Alejandro Estupiñán's questions

Is it good to do the database queries inside the php code? For example:

    <?
$restIds=$_SESSION['restaurants'];
$restIds=substr($restIds,0,strlen($restIds)-1);

$query="SELECT cli.restaurant_id as id, CONCAT(cli.nombre,' ',cli.sucursal) as nombre FROM s3menudt.clientes cli left join options opt on (opt.restId=cli.restaurant_id) WHERE cli.restaurant_id in ($restIds) and opt.controlCatalogos=1";

$result = $mysqli->query($query);

if (mysqli_num_rows($result)!=0)
{
    ?><label>Sucursal:</label>
    <select name="idSucursal" id="idSucursal"><?
    while($row = $result->fetch_array(MYSQLI_ASSOC))
    {
        if($fst==0 and $_SESSION['idSucursal']==''){
            $_SESSION['idSucursal']=$row['id'];
        }
        echo '<option id="'.$row['id'].'" value="'.$row['id'].'"';
        if($row['id']==$_SESSION['idSucursal']) echo ' selected';
        echo '>'.$row['nombre'].'</option>';

        $fst++;
    }
    ?></select><br><?
}
else{ echo "<script>alert('No hay sucursales configuradas para edición Web.'); window.top.location='../landing/index.php'; </script>"; die(); }
?>
</div>
<?
    $col = $col + 2;
    $jsvars .= 'var idSucursal = $("#idSucursal").val();
    ';
    $params .= 'idSucursal';
    $fsucursalCat = false;
}

elseif($fcatalogos){ ?>
<!-- ++++++++++++ CATÁLOGO ++++++++++++ -->
<div class="col-md-2">
<?

Does this cause vulnerabilities?

My code does not show errors but when I want to use the button it throws me this error, I would like to know how to solve it.

My code for the "REMOVE" button

 private void BtnQuitar_Click(object sender, EventArgs e)
  {
      foreach(DataGridViewRow item in DataGridViewSelectionArea.SelectedRows)
      {
          DataGridViewSelectionArea.RemoveAt(item.Index);

      }

    }

What I want to do is that when I click the accept button, I pass the selected data from the checkbox to the second datagrid view

using Parrot.Kitchen.App.Controller;
using Parrot.Kitchen.Business.Entities.Model;
using Parrot.Common.CustomComponent;
using System;
using System.Collections.Generic;
using System.ComponentModel;
using System.Data;
using System.Drawing;
using System.Linq;
using System.Text;
using System.Threading.Tasks;
using System.Windows.Forms;

namespace Parrot.Kitchen.App.Forms
{
    public partial class KitchenSetup : Form
    {
        private BizKitchenConfiguration bizKitchenConfiguration;
        private KitchenSetupController kitchenSetupController;
        private DataTable DataKitchenArea;
        private DataTable DataTableSection;
        private CustomDataGridView DataGridViewKitchenArea;
        private CustomDataGridView DataGridViewSectionArea;
        private CustomDataGridView DataGridViewSelectionArea;
        private MessageForm messageForm;
        private string TextMessage;
        private string KitchenAreaId;
        private string SectionAreaId;

        public KitchenSetup(BizKitchenConfiguration bizKitchenConfiguration)
        {
            this.bizKitchenConfiguration = bizKitchenConfiguration;
            this.kitchenSetupController = new KitchenSetupController(this.bizKitchenConfiguration.ConnectionIp);
            this.DataGridViewKitchenArea = new Parrot.Common.CustomComponent.CustomDataGridView();
            this.DataGridViewSectionArea = new Parrot.Common.CustomComponent.CustomDataGridView();
            this.DataGridViewSelectionArea = new Parrot.Common.CustomComponent.CustomDataGridView();
            this.TextMessage = String.Empty;
            this.AddDataGridView();
            InitializeComponent();
        }

        private void GetLicenceType()
        {
            if (this.bizKitchenConfiguration.ScreenId == -1)
            {

                this.bizKitchenConfiguration.TypeService = this.kitchenSetupController.GetLicenceType(
                    this.bizKitchenConfiguration.RestuarantId
                );
            }
            else 
            {
                this.bizKitchenConfiguration.TypeService = this.kitchenSetupController.GetKitchenParameter(
                    "Service_Type",
                    this.bizKitchenConfiguration.ScreenId
                );
            }

            if (this.bizKitchenConfiguration.TypeService.Equals("Food"))
            {
                this.ChkFoodService.Checked = true;
                this.DataGridViewKitchenArea.dataGridView.Visible = true;
                this.DataGridViewSectionArea.dataGridView.Visible = true;
                this.LbSectionArea.Visible = true;
            }
            else if (this.bizKitchenConfiguration.TypeService.Equals("Quick"))
            {
                this.ChkQuickService.Checked = true;
                this.DataGridViewKitchenArea.dataGridView.Visible = true;
                this.DataGridViewSectionArea.dataGridView.Visible = false;
                this.LbSectionArea.Visible = false;

            }
        }

        private void LoadConfigDataKitchenArea()
        {
            this.DataKitchenArea = new DataTable();
            this.DataKitchenArea.Columns.Add("Sel", typeof(bool));
            this.DataKitchenArea.Columns.Add("Id", typeof(int));
            this.DataKitchenArea.Columns.Add("Nombre", typeof(string));
        }

        private void LoadConfigDataTableSection()
        {
            this.DataTableSection = new DataTable();
            this.DataTableSection.Columns.Add("Sel", typeof(bool));
            this.DataTableSection.Columns.Add("Id", typeof(int));
            this.DataTableSection.Columns.Add("Nombre", typeof(string));
        }

        private void GetScreenId() 
        {
            string result = String.Empty;
            result = this.kitchenSetupController.GetScreenId();
            if (!String.IsNullOrEmpty(result))
            {
                this.bizKitchenConfiguration.ScreenId = Int32.Parse(result);
                this.TxtKitchenId.Text = result;
            }
            else 
            {
                int id = this.kitchenSetupController.GetIdScreen();
                this.bizKitchenConfiguration.ScreenId = -1;
                this.TxtKitchenId.Text = (id + 1).ToString();
            }
        }

        private void GetKitchenArea() 
        {
            List<BizKitchenArea> bizKitchenAreaList = this.kitchenSetupController.GetKitchenArea(
                    this.bizKitchenConfiguration.RestuarantId
                );
            if (bizKitchenAreaList != null && bizKitchenAreaList.Count >= 1) 
            {
                this.LoadConfigDataKitchenArea();
                foreach (BizKitchenArea kitchenArea in bizKitchenAreaList)
                {
                    DataRow dr = this.DataKitchenArea.NewRow();
                    dr["Sel"] = false;
                    dr["Id"] = kitchenArea.Id;
                    dr["Nombre"] = kitchenArea.KitchenAreaName;
                    this.DataKitchenArea.Rows.Add(dr);
                }
                this.DataGridViewKitchenArea.BindDataGridView(this.DataKitchenArea);
                this.DataGridViewKitchenArea.AddHeaderCheckBox();

            }
        }

        private void GetTableSection()
        {
            List<BizTableSection> bizTableSection = this.kitchenSetupController.GetTableSection(
                    this.bizKitchenConfiguration.RestuarantId
                );
            if (bizTableSection != null && bizTableSection.Count >= 1)
            {
                this.LoadConfigDataTableSection();
                foreach (BizTableSection tableSection in bizTableSection)
                {
                    DataRow dr = this.DataTableSection.NewRow();
                    dr["Sel"] = false;
                    dr["Id"] = tableSection.Id;
                    dr["Nombre"] = tableSection.SectionName;
                    this.DataTableSection.Rows.Add(dr);
                }
                this.DataGridViewSectionArea.BindDataGridView(this.DataTableSection);
                this.DataGridViewSectionArea.AddHeaderCheckBox();
                this.DataGridViewSectionArea.dataGridView.Columns["Nombre"].AutoSizeMode = DataGridViewAutoSizeColumnMode.Fill;
            }
        }

        private void AddDataGridView() 
        {
            // 
            // DataGridViewKitchenArea
            // 
            this.DataGridViewKitchenArea.dataGridView.Location = new System.Drawing.Point(38, 177);
            this.DataGridViewKitchenArea.dataGridView.Name = "DataGridViewKitchenArea";
            this.DataGridViewKitchenArea.dataGridView.Size = new System.Drawing.Size(250, 130);
            //
            // DataGridViewSectionArea
            // 
            this.DataGridViewSectionArea.dataGridView.Location = new System.Drawing.Point(28, 400);
            this.DataGridViewSectionArea.dataGridView.Name = "DataGridViewSectionArea";
            this.DataGridViewSectionArea.dataGridView.Size = new System.Drawing.Size(250, 108);
            //
            // DataGridViewSelectionArea
            //
            this.DataGridViewSelectionArea.dataGridView.Location = new System.Drawing.Point(80, 800);
            this.DataGridViewSelectionArea.dataGridView.Name = "DataGridViewSelectionArea";
            this.DataGridViewSelectionArea.dataGridView.Size = new System.Drawing.Size(500, 220);


            this.Controls.Add(this.DataGridViewSectionArea.dataGridView);
            this.Controls.Add(this.DataGridViewKitchenArea.dataGridView);
        }

        private void GetSelectedId()
        {
            this.KitchenAreaId = String.Empty;
            this.SectionAreaId = String.Empty;
            if (this.DataGridViewKitchenArea.dataGridView.RowCount > 0)
            {
                foreach (DataGridViewRow row in this.DataGridViewKitchenArea.dataGridView.Rows)
                {
                    if (Boolean.Parse(row.Cells["Sel"].Value.ToString()))
                    {
                        if (String.IsNullOrEmpty(this.KitchenAreaId))
                        {
                            this.KitchenAreaId += row.Cells["Id"].Value.ToString();
                        }
                        else 
                        {
                            this.KitchenAreaId += "," + row.Cells["Id"].Value.ToString();
                        }
                    }
                }
            }
            if (this.DataGridViewSectionArea.dataGridView.RowCount > 0)
            {
                foreach (DataGridViewRow row in this.DataGridViewSectionArea.dataGridView.Rows)
                {
                    if (Boolean.Parse(row.Cells["Sel"].Value.ToString()))
                    {
                        if (String.IsNullOrEmpty(this.SectionAreaId))
                        {
                            this.SectionAreaId += row.Cells["Nombre"].Value.ToString();
                        }
                        else
                        {
                            this.SectionAreaId += "," + row.Cells["Nombre"].Value.ToString();
                        }
                    }
                }
            }
        }

        private void SaveKitchenSetUp() 
        {
            int screenId;
            try
            {
                this.GetSelectedId();
                bool result = Int32.TryParse(TxtKitchenId.Text, out screenId);
                if (result)
                {
                    if (this.bizKitchenConfiguration.ScreenId == -1)
                    {
                        this.kitchenSetupController.SaveKitchenSetUp(
                                screenId,
                                this.KitchenAreaId,
                                this.SectionAreaId,
                                1
                            );
                        this.bizKitchenConfiguration.ScreenId = screenId;
                        this.bizKitchenConfiguration.KitchenAreaId = this.KitchenAreaId;
                        this.bizKitchenConfiguration.SectionAreaId = this.SectionAreaId;
                    }
                    else
                    {
                        this.kitchenSetupController.SaveKitchenSetUp(
                               screenId,
                               this.KitchenAreaId,
                               this.SectionAreaId,
                               2
                           );
                        this.bizKitchenConfiguration.ScreenId = screenId;
                        this.bizKitchenConfiguration.KitchenAreaId = this.KitchenAreaId;
                        this.bizKitchenConfiguration.SectionAreaId = this.SectionAreaId;
                    }
                    this.TextMessage = "La configuración de Kitchen fue guardada con éxito.";
                    this.ShowMessageForm();
                    this.Close();
                }
                else 
                {
                    this.TextMessage = "Hubo un error, porfavor intente de nuevo.";
                    this.ShowMessageForm();
                }
            }
            catch
            {
                this.TextMessage = "Hubo un error, porfavor intente de nuevo.";
                this.ShowMessageForm();
            }
        }

        private void ShowMessageForm()
        {
            this.messageForm = new MessageForm();
            this.messageForm.Owner = this;
            this.messageForm.TextMessage = this.TextMessage;
            this.messageForm.ShowDialog();
            this.messageForm.Dispose();
        }

        private void SelectDataGridView() 
        {
            if (!String.IsNullOrEmpty(this.bizKitchenConfiguration.KitchenAreaId)) 
            {
                var kitchenAreaId = this.bizKitchenConfiguration.KitchenAreaId.Split(',');

                foreach (DataGridViewRow row in this.DataGridViewKitchenArea.dataGridView.Rows)
                {
                    foreach (var id in kitchenAreaId)
                    {
                        if (row.Cells["Id"].Value.ToString().Equals(id))
                        {
                             row.Cells["Sel"].Value = true;
                        }
                    }
                }
            }
            if (!String.IsNullOrEmpty(this.bizKitchenConfiguration.SectionAreaId))
            {
                var sectionAreaId = this.bizKitchenConfiguration.SectionAreaId.Split(',');

                foreach (DataGridViewRow row in this.DataGridViewSectionArea.dataGridView.Rows)
                {
                    foreach (var id in sectionAreaId)
                    {
                        if (row.Cells["Nombre"].Value.ToString().Equals(id))
                        {
                            row.Cells["Sel"].Value = true;
                        }
                    }
                }
            }
        }

        public BizKitchenConfiguration GetKitchenSetup() 
        {
            return this.bizKitchenConfiguration;
        }

        private void KitchenSetup_Load(object sender, EventArgs e)
        {

            if (this.Owner.Owner != null)
            {
                this.Owner.Enabled = false;
                this.Owner.Visible = false;
                this.Location = new Point(
                    ((this.Owner.Owner.Width - this.Width) / 2),
                    ((this.Owner.Owner.Height - this.Height) / 2)
                );
            }
            else 
            {
                this.Owner.Enabled = false;
                this.Location = new Point(
                     ((this.Owner.Width - this.Width) / 2),
                     ((this.Owner.Height - this.Height) / 2)
                 ); 
            }
            this.TxtIpBd.Text = this.bizKitchenConfiguration.ConnectionIp;
            this.GetScreenId();
            this.GetKitchenArea();
            this.GetTableSection();
            this.GetLicenceType();
            this.SelectDataGridView();
        }

        private void KitchenSetup_FormClosed(object sender, FormClosedEventArgs e)
        {
            if (this.Owner.Owner != null)
            {
                this.Owner.Enabled = true;
                this.Owner.Visible = true;
            }
            else 
            {
                this.Owner.Enabled = true;
            }
        }

        private void BtnExit_Click(object sender, EventArgs e)
        {
            this.Close();
        }

        private void BtnSave_Click(object sender, EventArgs e)
        {
            this.SaveKitchenSetUp();
        }

        private void btnAgregr_Click(object sender, EventArgs e)
        {

        }

        private void LbKitchenArea_Click(object sender, EventArgs e)
        {

        }


    }
}

Can you leave me the steps to connect to my remote repository on github and update all the code that is in that repository, thanks

$ git remote add origin github.com/alexhak1/ThinkSecWEB
fatal: remote origin already exists

$ git push master
fatal: 'master' does not appear to be a git repository 
fatal: Could not read from remote repository. Please make sure you have the correct access rights and the repository exists

Hello I am trying to get the latitude and longitude in angular and save it in firebase it gives me this error

My code is:

import { Component, OnInit } from '@angular/core'; import { PlacesService } from '../services/places.service';

@Component({ selector: 'app-create', templateUrl: './create.component.html', styleUrls: ['./create.component.css'] }) export class CreateComponent { place: any = {}; constructor(private placesService: PlacesService) { } savePlace() {

var direccion = this.lugar.calle+','+ this.lugar.ciudad+','+this.lugar.pais;
this.lugaresService.obtenerGeoData(direccion)
.subscribe((result) => {
  this.lugar.lat = result[0].geometry.location.lat;
  this.lugar.lng = result[0].geometry.location.lng;
  this.lugar.id = Date.now();
  this.lugaresService.guardarLugar(this.lugar);
  alert('Indicio guardado con exito');
  this.lugar = {};
});

var direccion = this.lugar.calle+','+ this.lugar.ciudad+','+this.lugar.pais;
this.lugaresService.obtenerGeoData(direccion)
    .subscribe((result) =>{
      this.lugar.lat = this.lugar.lat = result[0].geometry.location.lat;;
      this.lugar.lng = this.lugar.lng = result[0].geometry.location.lng;
      this.lugar.id = Date.now();
      this.lugaresService.guardarLugar(this.lugar);
      alert('Indicio guardado con exito');
      this.lugar = {};
    });

}

}

/*

and so I call the service

public obtenerGeoData(direccion) {

    return this.http.get('http://maps.google.com/maps/api/geocode/json?address=' + direccion + '&key=<tu api key>'   );

}

Can you help me with that error please, I am using angular4.

package.json

{
  "name": "platzisquare",
  "version": "0.0.0",
  "license": "MIT",
  "scripts": {
    "ng": "ng",
    "start": "ng serve",
    "build": "ng build",
    "test": "ng test",
    "lint": "ng lint",
    "e2e": "ng e2e"
  },
  "private": true,
  "dependencies": {
    "@angular/animations": "^4.0.0",
    "@angular/common": "^4.0.0",
    "@angular/compiler": "^4.0.0",
    "@angular/core": "^4.0.0",
    "@angular/forms": "^4.0.0",
    "@angular/http": "^4.0.0",
    "@angular/platform-browser": "^4.0.0",
    "@angular/platform-browser-dynamic": "^4.0.0",
    "@angular/router": "^4.0.0",
    "core-js": "^2.4.1",
    "rxjs": "^5.4.1",
    "zone.js": "^0.8.14"
  },
  "devDependencies": {
    "@angular/cli": "1.2.7",
    "@angular/compiler-cli": "^4.0.0",
    "@angular/language-service": "^4.0.0",
    "@types/jasmine": "~2.5.53",
    "@types/jasminewd2": "~2.0.2",
    "@types/node": "~6.0.60",
    "codelyzer": "~3.0.1",
    "jasmine-core": "~2.6.2",
    "jasmine-spec-reporter": "~4.1.0",
    "karma": "~1.7.0",
    "karma-chrome-launcher": "~2.1.1",
    "karma-cli": "~1.0.1",
    "karma-coverage-istanbul-reporter": "^1.2.1",
    "karma-jasmine": "~1.1.0",
    "karma-jasmine-html-reporter": "^0.2.2",
    "protractor": "~5.1.2",
    "ts-node": "~3.0.4",
    "tslint": "~5.3.2",
    "typescript": "~2.3.3"
  }
}

I have made a login and I made that when I hit the enter button it would show a gif of loading... and it shows it but if in any case they are not the correct credentials follow the gif, that is, I don't know how to stop it, the idea is to put something like this as an if so that it says that if it gives an error, the gif stops, how would that be implemented?

function loading(){
imagen = '<img src="./img/loading.gif"/>';


 document.getElementById('loading2').innerHTML = imagen;
}