Home / Questions / 5982
Accepted
Jordi Castilla
Asked: 2020-03-19 05:10:19 +0800 CST 2020-03-19 05:10:19 +0800 CST

Get the smallest number greater than -1

  • 772

I have a method that gets the index to use in my own markdown system.

Indices are passed to the method and it has to return the lowest greater than -1 (not found) until now we only had negrita, cursivaand normalthe method was relatively simple (although it seems ugly to me with desire):

private int getValidIndexToUse(int indexOfBold, int indexOfItalics) {
    if (indexOfBold > -1 && indexOfItalics == -1)
        return indexOfBold;
    else if (indexOfItalics > -1 && indexOfBold == -1)
        return indexOfItalics;
    else 
        return indexOfBold > -1 && indexOfBold < indexOfItalics ? indexOfBold : indexOfItalics;
}

Now you have to add cursiva+negritaand underline and with this system the method becomes crazy.

Does anyone have any better ideas than nesting infinite if's?

java

2 Answers

  1. Best Answer

    The general problem of finding the smallest number in a set of numbers, provided that it is greater than some other number, could be further simplified with a variable-length parameter:

    private int getValidIndexToUse (int... indexes) {
  int toReturn = Integer.MAX_VALUE;

  for (int index : indexes)
      if (index > -1 && toReturn > index)
          toReturn = index;

  return toReturn;
}

    Or with Java 8, using a stream of ints:

    private int getValidIndexToUse (int... indexes) {
  return Arrays.stream(indexes).filter(i -> i > -1).min().orElse(Integer.MAX_VALUE);
}
    • 4

  2. Well, posting the question I have seen very clearly how to do it without complicating my life, very similar to if we wanted to get the same result by iterating through an array or list:

    private int getValidIndexToUse(int indexOfBold, int indexOfItalics, int indexOfUnderlined, int indexOfBoldItalic) 
{
    int toReturn = Integer.MAX_VALUE;

    if (indexOfBold > -1) toReturn = indexOfBold;
    if (indexOfItalics > -1 && toReturn > indexOfItalics) toReturn = indexOfItalics;
    if (indexOfUnderlined > -1 && toReturn > indexOfUnderlined) toReturn = indexOfUnderlined;
    if (indexOfBoldItalic > -1 && toReturn > indexOfBoldItalic) toReturn = indexOfBoldItalic;

    return toReturn;
}

    NOTE: it is not checked if they are all equal to -1 because the method call is inside a while (containsAny(stringToCheck, TAGS)), but if this check is not carried out, it is a point to check.

    What I have realized is that there was an error in approaching the problem and excessive complication in the old method, added to the fact that at certain moments you get confused, very complicated methods like the one in the question come out.

    I hope my temporary blindness will help someone in the future.

    • 2