Home / Questions / 502321
Accepted
Naidamag
Asked: 2022-05-10 07:46:11 +0800 CST 2022-05-10 07:46:11 +0800 CST

How can I apply a refactoring to my code in javascript

  • 772

I am learning javascript and my coaches have suggested me to refactor this code, I really don't know how I can do it, I would like you to guide me or show me examples of how to do it or how it could be by applying a refactoring.

In this function what I do is create a new object from an existing one, extracting data and using it to feed the new created object.

I can only use vanilla JS

console.time("total")
const computeDataTwo = (datos) => {
  const mapAthletes = new Map();
  for (let j = 0; j < datos.length; j++) {
    const element = datos[j];
    if (!mapAthletes.has(element.name)) {
      const initValueAthletes = {
        gold: 0,
        bronze: 0,
        silver: 0,
        total: 0
      }
      mapAthletes.set(element.name + " " + element.team, initValueAthletes)
    }
  }

  for (let j = 0; j < datos.length; j++) {
    const element = datos[j];
    const athletes = mapAthletes.get(element.name + " " + element.team);
    if (element.medal === "Gold") {
      athletes.gold = athletes.gold + 1;
    }
    if (element.medal === "Bronze") {
      athletes.bronze = athletes.bronze + 1;
    }
    if (element.medal === "Silver") {
      athletes.silver = athletes.silver + 1;
    }
    athletes.total = athletes.total + 1;
    mapAthletes.set(element.name + " " + element.team, athletes)

  }

  const arrayAthletes = [];
  mapAthletes.forEach((value, key) => {
    const totalMedalByAthletes = {
      name: key,
      gold: value.gold,
      silver: value.silver,
      bronce: value.bronze,
      total: value.total
    };
    arrayAthletes.push(totalMedalByAthletes);

  })
  return arrayAthletes
}
let datos = [{name:"pepe", team:"equipo1", medal: "Gold"},{name:"juan", team:"equipo2"}]
console.log(computeDataTwo(datos))
console.timeEnd("total")

javascript

2 Answers

  1. Best Answer

    Here I leave you a small refactoring of the code, I understand that it does everything the same that you were doing, let me know if it is useful to you.

    console.time("tiempo")
const computeDataTwo = (datos) => {
  return datos.map(atleta => {
    let respuesta = {
      nombre: atleta.name + " " + atleta.team,
      gold: 0,
      bronze: 0,
      silver: 0,
      total: 0
    }

    atleta?.medal != null && (respuesta[atleta.medal] += 1)

    respuesta.total = ["gold", "bronze", "silver"].reduce((acum, item) => respuesta[item] + acum, 0)

    return respuesta
  })

}

let datos = [{
  name: "pepe",
  team: "equipo1",
  medal: "gold"
}, {
  name: "juan",
  team: "equipo2"
}]

console.log(computeDataTwo(datos))
console.timeEnd("tiempo")

    And here I leave you another one with even less laps.

    console.time("tiempo")
const computeDataTwo = (datos) => {
  
  return datos.map(atleta => {
    
    let respuesta = {
      nombre: atleta.name + " " + atleta.team,
      total:0,
    }
    let medals = ["gold", "bronze", "silver"]
    
    medals.forEach(medal => {
      respuesta[medal] = atleta.medal == medal ? 1 : 0
      respuesta.total += respuesta[medal] 
    })
    
    return respuesta
  })
  
}

let datos = [{name:"pepe", team:"equipo1", medal: "gold"},{name:"juan", team:"equipo2"}]

console.log(computeDataTwo(datos))
console.timeEnd("tiempo")

    And another one, further reducing the code.

    console.time("tiempo")
const computeDataTwo = (datos) => {
  return datos.map(atleta => {
    let res = {
      nombre: atleta.name + " " + atleta.team,
      total: 0,
    };

    ["gold", "bronze", "silver"].forEach( medal => 
      res.total += res[medal] = atleta.medal == medal ? 1 : 0
    )
    return res
  })
}

let datos = [{
  name: "pepe",
  team: "equipo1",
  medal: "gold"
}, {
  name: "juan",
  team: "equipo2"
}]

console.log(computeDataTwo(datos))
console.timeEnd("tiempo")

    And since I'm a handle, here I leave you another one.

    console.time("tiempo")
const computeDataTwo = (datos, medallas = ["gold", "bronze", "silver"] ) => 
  datos.map(({name, team, medal, total = 0}) => {
    let res = {nombre : name + " " + team , total};
    medallas.forEach( medalla => res.total += res[medalla] = medal == medalla ? 1 : 0 )
    return res
  }
)

let datos = [{name:"pepe", team:"equipo1", medal: "gold"},{name:"juan", team:"equipo2"}]

console.log(computeDataTwo(datos))
console.timeEnd("tiempo")

    And the last one but it already gets very difficult to read and has no performance advantages.

    console.time("total")
const computeDataTwo = (datos, medallas = ["gold", "bronze", "silver"] ) => 
  datos.map( ({ name, team, medal, total = 0, r = {nombre:name + " " + team, total} }) => {
      medallas.forEach( m => r.total += r[m] = m == medal ? 1 : 0 ) 
      return r
  }
)

let datos = [{name:"pepe", team:"equipo1", medal: "gold"},{name:"juan", team:"equipo2"}]

console.log(computeDataTwo(datos))
console.timeEnd("total")

    • 3

  2. there I leave you an option that occurred to me greetings!

    let datos = [{
  name: "pepe",
  team: "equipo1",
  medal: "Gold"
}, {
  name: "juan",
  team: "equipo2"
}, {
  name: "toto",
  team: "equipo1",
  medal: "Gold"
}]

const computeDataThree = (datos) => {
  let arrayAcomodado = datos.map(atleta => {
    let total = 0
    const totalizador = (valor) => {
      total++
      return valor
    }
    return {
      name: atleta.name + " " + atleta.team,
      gold: atleta.medal == "Gold" ? totalizador(1) : 0,
      silver: atleta.medal == "Silver" ? totalizador(1) : 0,
      bronce: atleta.medal == "Bronce" ? totalizador(1) : 0,
      total
    }
  })
  return arrayAcomodado
}
console.log(computeDataThree(datos))

    • 1