Home / Questions / 305395
Accepted
Mr.Barbo
Asked: 2020-11-02 15:53:06 +0800 CST 2020-11-02 15:53:06 +0800 CST

How can I simplify my code?

  • 772

The thing is, I'm creating a window. This is the code for one of the buttons:

self.btn51 = tkinter.Button(master, text="0", command = self.printBut0)
self.btn51.place(x=180, y=380, width=120, height=40)
self.btn51.configure(font=("Caviar_Dreams", "15"))

What they do is: when I press the button it prints the digit "0" in an Entry. And this is the function that is called by the button:

def printBut0(self):
    self.txtCalc.insert(len(self.txtCalc.get()),"0")

The thing is that I repeat the function many times because there are several buttons with that function, but they print different digits, can I somehow make one for all the buttons?

And I appreciate if you can tell me something that I can improve.

python-3.x

1 Answers

  1. Best Answer

    To avoid duplicating code you have to identify what is changing. In this case, to create a button, vary the text, xe y. Then we put that data into a list of dictionaries:

    info_btns = [{"text": "0", "x": 180, "y": 380},
             # ...
             {"text": "9", "x": 540, "y": 500}}

    Since printBut0it depends on textthe button's, we adapt it so that it receives it as an argument by keyword :

    def printBut(self, text=""):
    self.txtCalc.insert(len(self.txtCalc.get()), text)

    Then, you can use a for loop to iterate through the list and create the buttons:

    for info_btn in info_btns:
    btn = tkinter.Button(master, text=info_btn["text"],
                         command=functools.partial(self.printBut,
                                                   text=info_btn["text"]))

    btn.place(x=info_btn["x"], y=info_btn["y"], width=120, height=40)
    btn.configure(font=("Caviar_Dreams", "15"))

    We use the function partialof the module functoolsso that the method printButreceives that textof the corresponding button. What it does is return the same method but with an argument already applied. An example of its use:

    from functools import partial
from itertools import repeat

def saludar(nombre, veces=1):
    for _ in repeat(None, veces):
        print(f"Hola {nombre}")

saludar_tres_veces = partial(saludar, veces=3)

saludar_tres_veces("mundo")
    • 1