Home / Questions / 291585
Accepted
Franqo Balsamo
Asked: 2020-09-10 10:27:00 +0800 CST 2020-09-10 10:27:00 +0800 CST

The correct position of the array is not accessed in a loop

  • 772

I'm trying to make a function that takes the value of x, where xis the position. For example:

  • 1 = gold
  • 2 = silver
  • 3 = bronze

And that in the other positions it is 0 or any number after 3 says "nothing". This is the code I have:

var array = ["oro", "plata", "bronce"]

function medallaSegunPuesto(x) {
  for (var i = 0; i < array.length; i++) {
    if (i == (x - 1)) {
      return array[i];
    } else {
      return "nada";
    }
  }
}

console.log(medallaSegunPuesto(3));

The problem is that when I put the elseit doesn't recognize position 2 or 3. Any suggestions?

javascript

3 Answers

  1. Best Answer

    You don't need a loop. It simply checks that the value is in the indicated range, otherwise it returns "nothing". Something like that:

    var array = ["oro","plata", "bronce"]

function medallaSegunPuesto(x){  
    if(x>0 && x<=array.length){
      return array[x-1];
    }else {return "nada";}  
}
console.log(medallaSegunPuesto(3));

    • 6

  2. It seems to me that it is even simpler using the logical or ||.

    var array = ["oro","plata", "bronce"]

const medallaSegunPuesto = (x)=>(array[x-1] || "nada");

console.log(medallaSegunPuesto(3));
console.log(medallaSegunPuesto(43));
console.log(medallaSegunPuesto(-1));

    • 3

  3. Although you already have correct solutions (and better than using a loop). I'm going to put the root of the problem (although I imagine you already know it) and a possible solution (although it would be easier and more efficient to choose another answer).

    The problem is in the if...else, which returns values ​​in both the ifand the else. That means that if the value is 1 it will return "gold", but for any other value, it will go into it elseand return "nothing" without even checking the rest of the indices.

    To fix this you could remove the elseand move the return "nada"just after the loop for:

    var array = ["oro", "plata", "bronce"]

function medallaSegunPuesto(x) {
  for (var i = 0; i < array.length; i++) {
    if (i == (x - 1)) {
      return array[i];
    }
  }
  return "nada";
}

console.log(medallaSegunPuesto(3));

    Again, this solution is not the best or quick way to solve the problem. But it could be useful if instead of iterating an array you were iterating over the indices of an object (although there are surely better solutions in that case as well).

    • 3