Home / Questions / 144469
Accepted
J. Rodríguez
Asked: 2020-03-09 07:24:02 +0800 CST 2020-03-09 07:24:02 +0800 CST

What is the correct way to evaluate the Progress of a Process? C#

  • 772

I have a process in which I make evaluations of the employees, to process the strikeouts, in the form of X number of employees that are displayed, the user can select the ones they want to process. While it is processing, I must show the Progress and percentage that the process is going through.

Problem: The progressBarincrease goes but labelPorcentajeit does not increase, it only shows 100% at the end of the process. The amount of data to process depends on the employees that the user selects, therefore, on occasions they can be few or many, I want to be able to appreciate the increase in progress during the process regardless of whether the data to be processed is few or many.

I have made a simple example to represent my problem:

private void btnEvaluar_Click(object sender, EventArgs e)
{
      labelProgreso.Visible = true;
      progressBar1.Visible = true;

      int progreso = 0, porciento = 0, totalEmpleadosProcesar = 0;

      for (int indice = 0; indice < 85; indice++) //Ciclo que representará los empleados seleccionados
      {
          totalEmpleadosProcesar = 85;  //Total de Empleados que seleccionó el usuario

          progreso++; //Aumentando el progreso 
          porciento = Convert.ToInt16(( ( (double)progreso / (double)totalEmpleadosProcesar ) * 100.00 )); //Calculo del porcentaje

          reportarProgreso(100, porciento); //función que cargará la barra de progreso

          //MessageBox.Show("Porciento: " + porciento);
      }

      MessageBox.Show("Completo...");
      labelProgreso.Visible = false;
      progressBar1.Visible = false;
}

Function that loads the ProgressBar:

private void reportarProgreso(int valorMaximo, int valor)
{
     progressBar1.Step = 1;
     progressBar1.Style = ProgressBarStyle.Continuous;
     progressBar1.Minimum = 0;
     progressBar1.Maximum = valorMaximo;

     if (valor > valorMaximo)
     {
         labelProgreso.Text = "100%";
         progressBar1.Value = valorMaximo;
     }
     else
     {
         labelProgreso.Text = Convert.ToString(valor) + "%";
         progressBar1.Value = valor;
     }
 }

To fix it I tried to use Thread.Sleep(1000);during the loop traversal, but still it doesn't show the percentage in thelabel

enter image description here

I don't want to use a Thread.Sleepbecause as I said if there are few employees it would work well, but if there are many and I have a set time for the Thread it would take a lot.

If I intervene each cycle interaction with a MessageBoxtest if it shows me the percentage in the label.

enter image description here

What am I doing wrong? What would be the correct way to represent the progress of a process?

Note : I don't care if the interface is still active during the process, that's why I haven't used Taskor BackGroundWorker...

Environment: Visual Studio 2010 (WindowsForms) & .NET NetFramework 4.0

c#

1 Answers

  1. Best Answer

    The problem is that your loop blocks the main thread of execution, preventing the label from being redrawed. To solve it I recommend using a BackgroundWorker.

    First, define the BackgroundWorkerin your form:

    BackgroundWorker bg = new BackgroundWorker();

    Then in the button event, you set the ProgressChanged, DoWorkand events RunWorkerCompletedand call their execution:

    private void btnEvaluar_Click(object sender, EventArgs e)
{
    bg.WorkerReportsProgress = true;
    bg.ProgressChanged += bg_ProgressChanged;
    bg.DoWork += bg_DoWork;
    bg.RunWorkerCompleted += bg_RunWorkerCompleted;
    bg.RunWorkerAsync();
    labelProgreso.Visible = true;
    progressBar1.Visible = true;
}

    Event DoWork(I've added one Sleepto show progress):

    private void bg_DoWork(object sender, DoWorkEventArgs e)
{
    int progreso = 0, porciento = 0, totalEmpleadosProcesar = 0;

    for (int indice = 0; indice < 85; indice++) //Ciclo que representará los empleados seleccionados
    {
        totalEmpleadosProcesar = 85;  //Total de Empleados que seleccionó el usuario

        progreso++; //Aumentando el progreso 
        porciento = Convert.ToInt16((((double)progreso / (double)totalEmpleadosProcesar) * 100.00)); //Calculo del porcentaje
        System.Threading.Thread.Sleep(500);
        bg.ReportProgress(porciento);
    }
}

    The event ProgressChangedwhere we update both the Progressbarand the Label:

    private void bg_ProgressChanged(object sender, ProgressChangedEventArgs e)
{
    // Change the value of the ProgressBar to the BackgroundWorker progress.
    progressBar1.Value = e.ProgressPercentage;
    progressBar1.Step = 1;
    progressBar1.Style = ProgressBarStyle.Continuous;
    progressBar1.Minimum = 0;
    progressBar1.Maximum = 100;

    if (e.ProgressPercentage > 100)
    {
        labelProgreso.Text = "100%";
        progressBar1.Value = progressBar1.Maximum;
    }
    else
    {
        labelProgreso.Text = Convert.ToString(e.ProgressPercentage) + "%";
        progressBar1.Value = e.ProgressPercentage;
    }
}

    Finally, the event RunWorkerCompletedthat is executed when the BackgroundWorkerhas finished:

    private void bg_RunWorkerCompleted(object sender, RunWorkerCompletedEventArgs e)
{
    MessageBox.Show("Completo...");
    labelProgreso.Visible = false;
    progressBar1.Visible = false;
}
    • 5